Fix modified libraries not being upgraded#1734
Merged
Conversation
This commit removes checks to prevent modified libraries from being upgraded. Originally intended to prevent accidental data loss of in-development libraries the safe guard may prevent updates in production environments unintentionally. It is not clear which mechanism modifies files on disk, but users have been reporting untouched libraries from not upgrading for this reason, repetitively.
Contributor
|
With latest version my setup is affected. I normally link 
but now PC replaces it with released If I don't remove |
Collaborator
Author
|
You wanted it, you got it. Don't cry! |
Contributor
|
I didn't want the libraries I work on replaced. Only ones I don't work on. I've suggested a solution that wouldn't have this problem - a new setting that would allow me to specify which libraries/packages shouldn't be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes checks to prevent modified libraries from being upgraded.
Originally intended to prevent accidental data loss of in-development libraries the safe guard may prevent updates in production environments unintentionally.
It is not clear which mechanism modifies files on disk, but users have been reporting untouched libraries from not upgrading for this reason, repetitively.