Limit phishing_blue_button_links to anchors that actually have a link#4817
Open
thunderkatz wants to merge 4 commits into
Open
Limit phishing_blue_button_links to anchors that actually have a link#4817thunderkatz wants to merge 4 commits into
thunderkatz wants to merge 4 commits into
Conversation
Dashboards point at regex.icontains(.raw, ...) as the cost driver on content-heavy anchors. filter() ran that regex against every matched anchor unconditionally; folding the check into a single AND chain inside any(), ordered cheapest-first, lets short-circuiting skip the regex whenever an anchor has no parseable link at all (href="#", tel:, mailto:, cid:, etc. never produce a .links entry) or its link is already excluded by domain.
github-actions
Bot
added
the
review-needed
Contributor
Shared Samples Sync - Action RequiredThis PR was not automatically synced to shared-samples because the author is not a member of the To enable syncing, an organization member can comment Once triggered, the rules will be synced on the next scheduled run (every 10 minutes). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the anchor's href is to something like "#", there's no point in evaluating its style. Move the faster filters first.
Associated samples
n/a
Associated hunts
https://platform.sublime.security/hunts/019f3cd1-39e4-7254-bd45-22d6bae942ec
Found 7 message groups:
href="#"and was still flagged by a medium severity rulehref=""surrounding no text, and were still flagged by multiple high severity rulesScreenshot (insights)
n/a