feat(mutators): Add default parameter mutator.#2863
feat(mutators): Add default parameter mutator.#2863Liam-Rougoor wants to merge 3 commits intomasterfrom
Conversation
# Conflicts: # src/Stryker.Core/Stryker.Core/Mutants/CsharpMutantOrchestrator.cs
|
richardwerkman
left a comment
richardwerkman
left a comment
There was a problem hiding this comment.
Nice! But we might need to think about some things before merging this
|
|
||
| namespace Stryker.Core.Mutants; | ||
|
|
||
| public interface ICsharpMutantOrchestrator |
There was a problem hiding this comment.
| public interface ICsharpMutantOrchestrator | |
| public interface ICSharpMutantOrchestrator |
There was a problem hiding this comment.
The original class is also called CsharpMutantOrchestrator..
Do you want me to keep it as is, or do you want me to rename both the interface and the class to CSharp...?
There was a problem hiding this comment.
Would be best to fix the casing
| } | ||
| } | ||
|
|
||
| public override MutationLevel MutationLevel => MutationLevel.Standard; |
There was a problem hiding this comment.
First of all, I would place this at the top of the class, not here. Like in our other mutator classes. And I think we should debate whether this should be a level standard mutation. This could add a lot of mutations.
| public override IEnumerable<Mutation> ApplyMutations(InvocationExpressionSyntax node, SemanticModel semanticModel) | ||
| { | ||
| var methodSymbol = (IMethodSymbol)semanticModel.GetSymbolInfo(node).Symbol; | ||
| if (methodSymbol is null) |
There was a problem hiding this comment.
I think we should check whether the symbol is internal or external. We might not want to mutate optional parameters of external APIs like System.Linq. @rouke-broersma what do you think?
There was a problem hiding this comment.
I'm not sure how we would be able to detect that
|
Merging with master was a bit of a hassle, it was easier to recreate #3024 |
3 participants
Closes #2848.