Google Sheets: buffer all rows and flush once per write() call#309
Open
Yostra wants to merge 11 commits intotx/nary-search-paginationfrom
Open
Google Sheets: buffer all rows and flush once per write() call#309Yostra wants to merge 11 commits intotx/nary-search-paginationfrom
Yostra wants to merge 11 commits intotx/nary-search-paginationfrom
Conversation
Yostra
force-pushed
the
sheet_brrr
branch
2 times, most recently
from
2e7aaad to
4a6afba
Compare
tonyxiao
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| `[google-sheets] write() error after ${Date.now() - writeStart}ms (records=${recordCount}, states=${stateCount}): ${err instanceof Error ? err.message : String(err)}` | ||
| ) | ||
| } finally { | ||
| if (cancelled) { |
Yostra
changed the base branch from
tx/progress-on-nary
to
tx/nary-search-pagination
Yostra
force-pushed
the
sheet_brrr
branch
6 times, most recently
from
fb3fbfc to
f60b0a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buffer all records and checkpoint messages during a single
write()call, flushing once at the end instead of every N rows. Removes thebatch_sizeconfig field from the Google Sheets destination schema.Test plan
single-flush writeunit test suite: verifies single append call per stream, checkpoint ordering after flush, and multi-stream + global state orderingbatch_sizereferencesLint, build & testCI green