Add a shimmering card view when loading card art#6355
Merged
wooj-stripe merged 3 commits intomasterfrom Apr 20, 2026
Merged
Conversation
|
|
||
| /// A view that displays a sliding shimmer animation overlay. | ||
| /// Used as a loading indicator while card art images are downloaded. | ||
| class ShimmerView: UIView { |
Collaborator
There was a problem hiding this comment.
Should we add some snapshot tests for this view?
Collaborator
Author
There was a problem hiding this comment.
I didn't consider it due to the animation.
We could write some unit tests that test to make sure the gradient has various alpha components, but that doesn't seem too valuable?
| Task { | ||
| let image = try? await DownloadManager.sharedManager.downloadImage(url: cardArtURL) | ||
| guard paymentMethodLogo.tag == cardArtURL.hashValue else { return } | ||
| paymentMethodLogo.removeShimmer() |
Collaborator
There was a problem hiding this comment.
Do we need to remove shimmer on line 376?
Collaborator
Author
There was a problem hiding this comment.
line 376 is showing me:
paymentMethodLogo.image = paymentMethodCellImage
Removing the shimmer as proposed in the PR (on line 371) seems appropriate since we've added it prior to loading, and we should be removing it irregardless of the card art image loads or we fallback to the network logo.
porter-stripe
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds shimmering view that can be used to indicate an image loading
Motivation
Card art
Testing
Manual testing
Changelog