Fix collectPaymentMethod returning stale result on iOS dismiss#6354
Closed
finn-stripe wants to merge 1 commit intomasterfrom
Closed
Fix collectPaymentMethod returning stale result on iOS dismiss#6354finn-stripe wants to merge 1 commit intomasterfrom
finn-stripe wants to merge 1 commit intomasterfrom
Conversation
The async collectPaymentMethod wrapper read self.paymentMethodPreview after the callback fired. On dismiss with shouldClearSelection=false, this returned a stale preview from a prior selection instead of nil. Pass the result explicitly through the completion closure so cancel always returns nil, matching Android behavior. Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix LinkController.collectPaymentMethod to return nil on dismiss instead of the previously selected payment method. The completion handler now passes a PaymentMethodPreview? directly, making the cancellation vs. selection result explicit.
Motivation
https://jira.corp.stripe.com/browse/ONRAMP-342
When calling collectPaymentMethod in the stripe-react-native onramp SDK, iOS and Android behaved inconsistently when the user dismissed the bottom sheet by tapping X. iOS returned displayData for the most recently selected payment method even on dismiss, while Android always returned cancellation. This change aligns iOS with Android: tapping X always returns nil (cancellation), regardless of whether a payment method was previously selected during the session.
Test plan
Rollout/revert plan
Monitoring plan