Use Nil as Default Value for Link Supported Payment Methods#6349
Open
jkelle-stripe wants to merge 1 commit intomasterfrom
Open
Use Nil as Default Value for Link Supported Payment Methods#6349jkelle-stripe wants to merge 1 commit intomasterfrom
jkelle-stripe wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modifies the default value of
supportedPaymentMethodTypesMotivation
In #5309, we introduced parametric filtering of supported payment methods. We used a default value of
allCases, which works for our current feature set. However, in #6342, we'll want to remove theintersectionon these filtered payment methods if non are provided to allow for unknown PMs to be included in the list. In this PR, we'll keep the same intersection functionality of all cases, but modify the piping of these values to usenilinstead ofallCasesas the default value. In #6342, we remove the allCases intersection entirely ifnilfiltered payment methods are passed in.Demos
test.harness.mov
mpe.mov