public-api-check: exempt alpha SPI APIs from version bump requirement#6312
Closed
jeanregisser wants to merge 1 commit intomasterfrom
Closed
public-api-check: exempt alpha SPI APIs from version bump requirement#6312jeanregisser wants to merge 1 commit intomasterfrom
jeanregisser wants to merge 1 commit intomasterfrom
Conversation
APIs tagged with `@_spi(*Alpha)` are pre-release and not stable contracts, so they should not require a MINOR version bump alongside `@_spi(STP)`. Committed-By-Agent: claude
Member
Author
|
Closing in favor of #6314 — after discussion with the iOS team, the check is working as intended. Alpha SPI changes should still require a MINOR bump to avoid silently breaking consumers like React Native. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the public API check to exempt
@_spi(*Alpha)declarations from the MINOR version bump requirement, alongside the existing@_spi(STP)exemption.Also renames
non_stp_spi_line?tostable_spi_line?to better reflect its updated purpose.Motivation
Alpha SPI APIs (e.g.
@_spi(CryptoOnrampAlpha)) are pre-release, unstable contracts not intended for general consumption. Requiring a MINOR version bump for changes to them doesn't make sense — they carry no stability guarantees.This was surfaced by #6230, where the check incorrectly blocked a CryptoOnramp SDK PR for changing
@_spi(CryptoOnrampAlpha)APIs.Testing
Logic change is straightforward. The check is exercised on every PR via the
verify-public-interfaceworkflow.Changelog
N/A, CI tooling change only.