[Identity] Adding in new error logs and improving many existing ones#6243
Merged
[Identity] Adding in new error logs and improving many existing ones#6243
Conversation
Pearapps
changed the title
added 3 commits
March 24, 2026 16:23
Pearapps
changed the title
added 6 commits
April 8, 2026 16:53
This reverts commit a722c95.
cjmisenas-stripe
requested changes
Apr 16, 2026
| } | ||
|
|
||
| private extension MLModelLoader { | ||
| static func logModelLoadingError( |
There was a problem hiding this comment.
Does this also log which models had a loading error?
Collaborator
Author
There was a problem hiding this comment.
Not in this helper. The higher-level IdentityMLModelLoader logs include ml_model_type (document / face / shared), though.
cjmisenas-stripe
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds in a variety of new error logs so that we can gather more information on the error states in the identity flow.
Additionally, this adds in a bunch more details to existing and new logs to help us figure out more when we go to read the logs.
Went through a handful of scenarios to make sure I saw the analytics log logged to console (which we have enabled in debug)