Docs: Outdated terminology in token meter docs comments#380
Open
tuanaiseo wants to merge 1 commit intostripe:mainfrom
Open
Docs: Outdated terminology in token meter docs comments#380tuanaiseo wants to merge 1 commit intostripe:mainfrom
tuanaiseo wants to merge 1 commit intostripe:mainfrom
Conversation
The file-level comments refer to "token-billing" even though the package/module is now named `token-meter`. This creates confusion for contributors searching for the current module name and can propagate stale terminology into external docs. Affected files: types.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The file-level comments refer to "token-billing" even though the package/module is now named
token-meter. This creates confusion for contributors searching for the current module name and can propagate stale terminology into external docs.Severity:
lowFile:
llm/token-meter/types.tsSolution
Update the header comment to use consistent naming, e.g. "Type definitions for token-meter".
Changes
llm/token-meter/types.ts(modified)Testing