fix: refine automatic album art detection in generic folders#2069
Open
hthienloc wants to merge 1 commit intostrawberrymusicplayer:masterfrom
Open
fix: refine automatic album art detection in generic folders#2069hthienloc wants to merge 1 commit intostrawberrymusicplayer:masterfrom
hthienloc wants to merge 1 commit intostrawberrymusicplayer:masterfrom
Conversation
Prioritize known cover art filenames (cover, front, folder, etc.) and disable the 'take any image' fallback logic when music files are located in generic system folders like Downloads or Desktop. This prevents unrelated images from being incorrectly assigned as album art.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refines the automatic album art detection logic in
Song::InitArtAutomaticto prevent unrelated images from being picked up when music files are stored in generic system folders.Motivation
When a user plays a song from a folder like
Downloads,Desktop, orDocuments, Strawberry would often pick the first available image in that folder as the album art. This results in incorrect and distracting cover art (e.g., screenshots or downloaded icons) being assigned to songs.Changes
Downloads,Desktop,Documents, orHome).cover,front,folder,albumart,album).Testing
~/Downloadsare no longer picked up as album art.cover.jpg) are still detected in~/Downloads.