Upgrade the MPris2 definitions

[Vinzzzze]

Properties / methods updated :

• Tracks : return all the tracks in the current playlist
• GetTracksMetadata : return the specified tracklist metadata using Song::ToXesam method
• AddTracks : add the tracks to the current playlist
• RemoveTracks : remove the tracks from the current playlist
• GoTo : go to the specified track in the current playlist
• GetPlaylists : use the order parameter
• PlaylistItemsAdded : To know when a track is really added to a playlist
• PlaylistItemsRemoved : To know when a track is really removed from a playlist

[jonaski]

Create some new MPris properties / methods, my main worry is about the Shuffle property that was a boolean property and I migrated it to a string property. May be I should have created a new property. Properties / methods updated :

Shuffle needs to be bool: https://specifications.freedesktop.org/mpris/latest/Player_Interface.html#Property:Shuffle
And I'm not sure we should add methods that are not part of the official specifications either.

[Vinzzzze]

ok, I will change my PR to match these requirements : no new method and Shuffle will be bool

[Copilot]

Pull request overview

This PR updates the MPRIS2 implementation to expose a fuller TrackList/Playlists feature set (track enumeration, metadata lookup, add/remove/goto operations, and playlist ordering), and adds support for an “Album” loop mode.

Changes:

• Expose playlist playback order indices via Playlist::virtual_items() for MPRIS TrackList integration.
• Implement Tracks, GetTracksMetadata, AddTrack, RemoveTrack, and GoTo in Mpris2.
• Add basic sorting support in GetPlaylists(order, reverse_order) and extend LoopStatus handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
src/playlist/playlist.h	Adds a getter to expose virtual_items_ (playback order indices) to other components (MPRIS).
src/mpris2/mpris2.cpp	Implements/updates MPRIS2 TrackList and Playlists behaviors (loop status, tracks enumeration, metadata, add/remove/goto, playlist ordering).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 11 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jonaski]

According to the specifications https://mpris2.readthedocs.io/en/latest/mpris2.tracklist.html, the track ID's need to be unique and not change, when reshuffling, what songs virtual_items_ point to will change so we can't use that, so I removed use of that so it's using the playlist item indexes, but I realize we can't use that either since it changes when inserting, removing or moving songs in the playlist.
We can't use song_id, because only collection songs have that, so I think we need to introduce a unique identifier to the playlist items.
Also, according to the documentation, TrackList should not return the entire playlist, but only the items in the queue + some of the previously played songs.
And AddTrack / RemoveTrack need to emit TrackAdded / TrackRemoved, but the signals needs to be emitted after the songs have been inserted in the playlist and a unique ID has been allocated.
So implementing this is much more complicated than I originally thought.

[Vinzzzze]

According to the specifications https://mpris2.readthedocs.io/en/latest/mpris2.tracklist.html, the track ID's need to be unique and not change, when reshuffling, what songs virtual_items_ point to will change so we can't use that, so I removed use of that so it's using the playlist item indexes, but I realize we can't use that either since it changes when inserting, removing or moving songs in the playlist. We can't use song_id, because only collection songs have that, so I think we need to introduce a unique identifier to the playlist items. Also, according to the documentation, TrackList should not return the entire playlist, but only the items in the queue + some of the previously played songs. And AddTrack / RemoveTrack need to emit TrackAdded / TrackRemoved, but the signals needs to be emitted after the songs have been inserted in the playlist and a unique ID has been allocated. So implementing this is much more complicated than I originally thought.

Ok, got it. If you want, we can close this PR until having the right idea to solve theses issues. I am very interested by being able to control the player from the command line.
May be I should rather implement some new options in that purpose, or I can have a look to the MPris requirement and exchange with you on the solution I want to put in place before submitting a PR.

[jonaski]

Let's just leave this open, then add the required changes separately, merge those first, then rebase this after it's implented.
We can implement a unique ID when new playlist items are inserted, which is saved to the playlist_items so it doesn't change when playlists are re-opened, I think QUuid: https://doc.qt.io/qt-6/quuid.html would be sufficient.
Then implement a function to Playlist which returns the previous 20 and next 20 ID's for use with MPRIS2 taking played indexes and next virtual items and queued items into consideration.
There also need to be a signal when items are inserted / removed back to MPRIS2 but only for the changes through MPRIS2 AddTrack / RemoveTrack, a bit unsure how difficult that would be to implement.

[Vinzzzze]

Hello,
I created the PR #2059 to add the unique identifier to items, this PR had to be validated first.
This PR is also included in this PR (that's why there are two commits, I will maintain them up-to-date) to show you the solution I imagine.
I think that now the code fulfill the mpris specifications.