Changing StartupWMClass

[Kyuyrii]

The previous StartupWMClass was incorrect.

[jonaski]

Why is it incorrect?

[Kyuyrii]

Why is it incorrect?

KDE allows you to discover the WMClass of the window by using the window properties detection function (I don't know exactly what this is called in English), which shows org.strawberrymusicplayer.strawberry.

[jonaski]

jonas@jonas:~> xprop WM_CLASS
WM_CLASS(STRING) = "strawberry", "Strawberry"

[Kyuyrii]

jonas@jonas:~> xprop WM_CLASS
WM_CLASS(STRING) = "strawberry", "Strawberry"

Are you on Xorg?

In the Wayland session, "xprop WM_CLASS" doesn't work.

When using the KDE function in the Xorg session, it says that WMClass is "Strawberry," but DEs are migrating to Wayland, so I imagine it doesn't make much sense to continue using Xorg's WMClass.

[jonaski]

I added StartupWMClass because of issue #305, if we change this we need to be sure it still works with X11.
X11 is still used and the last time I checked not long ago there were still issues with KDE/Strawberry and Wayland.
Most other programs seem to use just the application name for StartupWMClass too:

jonas@jonas:~> grep StartupWMClass /usr/share/applications/org.*
/usr/share/applications/org.kde.ark.desktop:StartupWMClass=ark
/usr/share/applications/org.kde.digikam.desktop:StartupWMClass=digikam
/usr/share/applications/org.kde.dolphin.desktop:StartupWMClass=dolphin
/usr/share/applications/org.kde.elisa.desktop:StartupWMClass=elisa
/usr/share/applications/org.kde.gwenview_importer.desktop:StartupWMClass=gwenview
/usr/share/applications/org.kde.heaptrack.desktop:StartupWMClass=heaptrack_gui
/usr/share/applications/org.kde.k3b.desktop:StartupWMClass=k3b
/usr/share/applications/org.kde.kate.desktop:StartupWMClass=kate
/usr/share/applications/org.kde.kdenlive.desktop:StartupWMClass=kdenlive
/usr/share/applications/org.kde.kid3.desktop:StartupWMClass=kid3
/usr/share/applications/org.kde.kolourpaint.desktop:StartupWMClass=kolourpaint
/usr/share/applications/org.kde.kompare.desktop:StartupWMClass=kompare
/usr/share/applications/org.kde.konsole.desktop:StartupWMClass=konsole
/usr/share/applications/org.kde.konversation.desktop:StartupWMClass=konversation
/usr/share/applications/org.kde.krdc.desktop:StartupWMClass=krdc
/usr/share/applications/org.kde.krename.desktop:StartupWMClass=krename
/usr/share/applications/org.kde.krita.desktop:StartupWMClass=krita
/usr/share/applications/org.kde.okular.desktop:StartupWMClass=okular
/usr/share/applications/org.kde.showfoto.desktop:StartupWMClass=showfoto
/usr/share/applications/org.kde.skanlite.desktop:StartupWMClass=skanlite
/usr/share/applications/org.musicbrainz.Picard.desktop:StartupWMClass=Picard
/usr/share/applications/org.qt-project.qtcreator.desktop:StartupWMClass=qtcreator
/usr/share/applications/org.remmina.Remmina.desktop:StartupWMClass=org.remmina.Remmina
/usr/share/applications/org.scummvm.scummvm.desktop:StartupWMClass=scummvm
/usr/share/applications/org.strawberrymusicplayer.strawberry.desktop:StartupWMClass=strawberry

What's changing StartupWMClass fixing?

[Kyuyrii]

From what I've seen, Elisa uses StartupWMClass=elisa, but in Wayland the WMClass is org.kde.elisa. It would be better if they used the Wayland WMClass. If the DEs/compositors use the WMClass information from the .desktop, this difference between the .desktop WMClass and the actual WMClass can cause problems involving icons and pinned apps.

[Danny3]

Guys, please make sure the change doesn't affect the functionality on Wayland and try to not focus too much on X, that will be abandoned starting with Plasma 6.8:
https://www.phoronix.com/news/KDE-Plasma-68-Wayland-Exclusive
Which will probably be released next year, considering that 6.7 should be released at the end of this year after the last point release of 6.6, following this calendar:
https://community.kde.org/Schedules/Plasma_6#Future_releases