Skip to content

JavaToLaurel: emit a procedure (not a function) for @Pure methods #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tautschnig wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

JavaToLaurel: emit a procedure (not a function) for @Pure methods #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions ...main/java/org/strata/jverify/verifier/compiler/generator/laurel/JavaToLaurelCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,21 +465,22 @@ && bodyContainsLoop(method.body)) {
? Optional.of(body(methodBody))
: Optional.empty();

// Strata rejects transparent (visible-body) procedures unless they're functional;
// emit an OpaqueSpec to mark the body opaque otherwise. Pure functions stay
// transparent only when they have no ensures clauses (the schema can't carry
// ensures without an OpaqueSpec wrapper).
// A @Pure method with no ensures is emitted as a *transparent*
// procedure (visible body, no OpaqueSpec); with ensures it is
// opaque (the schema can't carry ensures without an OpaqueSpec
// wrapper). Non-pure methods are always opaque.
// modifies is always empty: jverify doesn't yet emit modifies clauses.
boolean canStayTransparent = isPure && ensures.isEmpty();
Optional<OpaqueSpec> optSpec = canStayTransparent
? Optional.empty()
: Optional.of(opaqueSpec(ensures, List.of()));

Procedure proc = isPure
? function(toSourceRange(method), methodName, params,
retType, Optional.empty(), requires, Optional.empty(), optSpec, optBody)
: procedure(toSourceRange(method), methodName, params,
retType, Optional.empty(), requires, Optional.empty(), optSpec, optBody);
// Laurel functions are being removed (Strata #1408); a @Pure method
// now emits a procedure (transparent when it has no ensures) rather
// than a function. Transparent procedures give callers the same
// body-visible semantics that functions previously did.
Procedure proc = procedure(toSourceRange(method), methodName, params,
retType, Optional.empty(), requires, Optional.empty(), optSpec, optBody);
procedures.add(proc);
}

Expand Down
Loading