Boole: add test coverage for typed seq_of_* literal lowering - #1299
Draft
MikaelMayer wants to merge 40 commits into
Draft
Boole: add test coverage for typed seq_of_* literal lowering#1299MikaelMayer wants to merge 40 commits into
MikaelMayer wants to merge 40 commits into
Conversation
PR #1214 already fixed the untyped seqEmptyOp issue by introducing seqLitToCore which passes the element type. This commit adds test coverage for the bv8, bv16, and bv64 variants that were not previously tested, completing the verification that all seq_of_* literals lower to a typed Sequence.empty.
Contributor
Author
|
🤖⛏️ The core fix for this issue (passing element type to |
…-of-literals-use-untyped-seqemp
MikaelMayer
commented
May 29, 2026
MikaelMayer
left a comment
MikaelMayer
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖🔍 Clean PR. Adds test coverage for the three remaining seq_of_* variants (bv8, bv16, bv64), completing coverage of all element types defined in the grammar. Tests follow the established pattern and pass successfully.
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
Procedure.Body was changed from List Statement to an inductive (structured | cfg) in #1342. Use getStructured to extract the statement list before iterating.
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
…-of-literals-use-untyped-seqemp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1297
The underlying bug (seq_of_* literals using untyped
seqEmptyOp) was already fixed by PR #1214, which introducedseqLitToCorepassing the element type toCore.seqEmptyOp (some elemTy).This PR adds test coverage for the
bv8,bv16, andbv64variants that were not previously tested, completing the verification that allseq_of_*literals lower to a typedSequence.empty.Tested: existing tests pass, new
#guard_msgstests added for all remaining element types.