Robin aws/lake skimmer - #1061
Draft
robin-aws wants to merge 23 commits into
Draft
Conversation
This reverts commit e681e29.
github-actions
Bot
added
the
dependencies
3 tasks
tydeu
reviewed
May 5, 2026
Comment on lines
+46
to
+47
| - **`declaration`** (`def`, `theorem`, etc.) is pure. | ||
| - **Inspection commands** (`#check`, `#print`, etc.) are pure. |
There was a problem hiding this comment.
FYI, any command that elaborates an arbitrary Lean term (e.g., def, theorem, #check) is possibly impure. A term can execute arbitrary code during elaboration through both custom elaborators and builtin ones (e.g., run_tac, include_str).
Contributor
Author
There was a problem hiding this comment.
Ah thanks for the heads up. This "audit" was entirely Kiro-driven and I hadn't even reviewed it myself yet. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.