Skip to content

(Closes #3364) Prepare for release 3.3.0#3470

Open
arporter wants to merge 3 commits into
masterfrom
3364_master_3_3_0
Open

(Closes #3364) Prepare for release 3.3.0#3470
arporter wants to merge 3 commits into
masterfrom
3364_master_3_3_0

Conversation

@arporter

Copy link
Copy Markdown
Member

Just updates the version number in the two locations.
At merge time we'll need to update the changelog too.
As the 'update to fparser 0.2.4' has just gone on, we know that all of the fparser settings in the various workflow files are correct already.

@arporter

Copy link
Copy Markdown
Member Author

Ready for review (@hiker or @sergisiso) and for final testing at the Met Office (@andrewcoughtrie). Sergi tells me that he's also brought the associated lfric_apps PR up-to-date: MetOffice/lfric_apps#545

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4216b9a) to head (530f770).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3470   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          395       395           
  Lines        55199     55199           
=========================================
  Hits         55199     55199           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso sergisiso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter Since this cycle we moved to pyproject so I attempted the build manually and everything worked, but it has the same warning that we fixed in fparser:

SetuptoolsDeprecationWarning: `project.license` as a TOML table is deprecated
!!

        ********************************************************************************
        Please use a simple string containing a SPDX expression for `project.license`. You can also use `project.license-files`. (Both options available on setuptools>=77.0.0).

        By 2027-Feb-18, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.

        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
        ********************************************************************************

Could you fix it here as well please?

Comment thread src/psyclone/version.py
__MAJOR__ = 3
__MINOR__ = 3
__MICRO__ = 1
__MICRO__ = 0

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate that we have to move a number down. How did that happen? Was it because we did a release candidate and didn't do the associated release?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We did the rc release and then I bumped the working version to 3.3.1-dev. In retrospect this should probably have been 3.3.0-rc2-dev.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I was expecting that we'd make the release shortly after the rc but in the end, it didn't make sense to do that.)

@arporter

Copy link
Copy Markdown
Member Author

License string updated (GH wouldn't let me respond to the comment directly) and I've pushed the changes.
Ready for another look/to hear back from the MO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants