Skip to content

Update to fparser 0.2.4#3440

Merged
arporter merged 20 commits into
masterfrom
test_fparser
Jun 26, 2026
Merged

Update to fparser 0.2.4#3440
arporter merged 20 commits into
masterfrom
test_fparser

Conversation

@sergisiso

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bb44e5d) to head (2718e5d).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3440   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          395       395           
  Lines        55199     55199           
=========================================
  Hits         55199     55199           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso sergisiso changed the title Update and test fparser Update to fparser 0.2.3 Jun 11, 2026
@sergisiso

Copy link
Copy Markdown
Collaborator Author

One pytest failed, I am a bit confused because adding the same fortran snippet into a file and doing: fparser2 test.f90 and psyclone test.f90 both succeed.

@arporter

Copy link
Copy Markdown
Member

One pytest failed, I am a bit confused because adding the same fortran snippet into a file and doing: fparser2 test.f90 and psyclone test.f90 both succeed.

Could it be a Python version thing?

@sergisiso

sergisiso commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

No, I am using the same environment for everything. The problem is that the test requests a fixed_form parser and the snippet is free_form. Maybe before we just ignored the syntaxerror because it starts with a blankline and we fixed this issue now.

This is not a problem in most cases because our FortranReader defaults to free_form True. But this particular tests uses the FparserReader that defaults to free_form False.

@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter @LonelyCat124 This is ready for review

@arporter arporter added Blocked An issue/PR that is blocked by one or more issues/PRs. and removed ready for review labels Jun 16, 2026
@arporter

Copy link
Copy Markdown
Member

I suggest we pause this while we get 0.2.4 of fparser out.

@sergisiso sergisiso added ready for review and removed Blocked An issue/PR that is blocked by one or more issues/PRs. labels Jun 26, 2026
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter I unblocked the PR and marked ready for review again.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergi, you just need to put the GHA workflow back to using pypi and I have a question about why other changes in that file are showing.

Comment thread .github/workflows/python-package.yml Outdated
Comment thread .github/workflows/python-package.yml
@sergisiso

Copy link
Copy Markdown
Collaborator Author

@arporter ready for another look

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. I'll double-check the integration tests since we've updated the workflow files.

@arporter arporter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ITs were all green so I'll proceed to merge.

@arporter arporter merged commit 4216b9a into master Jun 26, 2026
15 checks passed
@arporter arporter deleted the test_fparser branch June 26, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants