Update to fparser 0.2.4#3440
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3440 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 395 395
Lines 55199 55199
=========================================
Hits 55199 55199 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
One pytest failed, I am a bit confused because adding the same fortran snippet into a file and doing: |
Could it be a Python version thing? |
|
No, I am using the same environment for everything. The problem is that the test requests a fixed_form parser and the snippet is free_form. Maybe before we just ignored the syntaxerror because it starts with a blankline and we fixed this issue now. This is not a problem in most cases because our FortranReader defaults to free_form True. But this particular tests uses the FparserReader that defaults to free_form False. |
|
@arporter @LonelyCat124 This is ready for review |
|
I suggest we pause this while we get 0.2.4 of fparser out. |
|
@arporter I unblocked the PR and marked ready for review again. |
arporter
left a comment
There was a problem hiding this comment.
Thanks Sergi, you just need to put the GHA workflow back to using pypi and I have a question about why other changes in that file are showing.
|
@arporter ready for another look |
arporter
left a comment
There was a problem hiding this comment.
All good now. I'll double-check the integration tests since we've updated the workflow files.
arporter
left a comment
There was a problem hiding this comment.
ITs were all green so I'll proceed to merge.
No description provided.