chore: apply fixes to all the codebase with cargo clippy --fix - #739
Open
plusvic wants to merge 5 commits into
Open
chore: apply fixes to all the codebase with cargo clippy --fix#739plusvic wants to merge 5 commits into
cargo clippy --fix#739plusvic wants to merge 5 commits into
Conversation
According to the Protobuf Specification the fields in a constant message can be separated by spaces, commas or semicolons. All the following variants are accepted by the official compiler`protoc`.
```
{foo: 1,bar: 2,baz: 3,}
{foo: 1;bar: 2;baz: 3;}
{foo: 1 bar: 2 baz: 3}
{foo: 1,bar: 2;baz: 3}
{foo: 1,bar: 2 baz: 3}
```
Checking the source code with Clippy is a good practice that helps maintaining the code in good shape and ensures an homogeneous style. Most of the automatic fixes in this commit are small cosmetic changes, but some of them improve legibility or even performance. If this change is accepted I plan to keep applying more fixes for hints that Clippy reports but can't fix automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the source code with Clippy is a good practice that helps maintaining the code in good shape and ensures an homogeneous style. Most of the automatic fixes in this commit are small cosmetic changes, but some of them improve legibility or even performance.
If this change is accepted I plan to keep applying more fixes for hints that Clippy reports but can't fix automatically.