Skip to content

Harden Stellar CLI plugin sanitization against markdown/HTML injection #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fnando wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Harden Stellar CLI plugin sanitization against markdown/HTML injection #2537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a5e06
Escape other markdown control characters.
fnando Jun 25, 2026
1885156
Wrap paragraph.
fnando Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 35 additions & 12 deletions scripts/stellar_cli_plugins.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,39 @@ import https from "https";
// E.g. "user/repo"
const excludePlugins = ["haqnawaz03329-debug/haqnawaz"];

// GitHub repo descriptions are attacker-controlled (anyone can tag a repo with
// the `stellar-cli-plugin` topic), and this content is injected into MDX, which
// renders HTML/JSX. Neutralize characters that could execute as markup/script.
function sanitize(value) {
return (value || "")
.replace(/&/g, "&")
.replace(/</g, "&lt;")
.replace(/>/g, "&gt;")
.replace(/{/g, "&#123;")
.replace(/}/g, "&#125;");
const MD_ENTITIES = {
"&": "&amp;",
"<": "&lt;",
">": "&gt;",
'"': "&quot;",
"'": "&#39;",
"*": "&#42;",
_: "&#95;",
"`": "&#96;",
"[": "&#91;",
"]": "&#93;",
"(": "&#40;",
")": "&#41;",
"#": "&#35;",
"+": "&#43;",
"-": "&#45;",
".": "&#46;",
"!": "&#33;",
"|": "&#124;",
"~": "&#126;",
"\\": "&#92;",
"{": "&#123;",
"}": "&#125;",
"=": "&#61;",
":": "&#58;",
$: "&#36;",
};

function escape(value) {
return String(value ?? "")
.replace(/\s+/g, " ")
.trim()
.replace(/[&<>"'*_`\[\]()#+\-.!|~\\{}=:$]/g, (ch) => MD_ENTITIES[ch]);
}

function exportMDX(data) {
Expand All @@ -23,9 +46,9 @@ function exportMDX(data) {
return buffer;
}

const plugin = `### [${sanitize(item.full_name)}](${encodeURI(item.html_url)})
const plugin = `### [${escape(item.full_name)}](${encodeURI(item.html_url)})

${sanitize(item.description)}
<p>${escape(item.description)}</p>

[${encodeURI(item.html_url)}](${encodeURI(item.html_url)})
`;
Expand Down
Loading