fix(browser): export saved files with write output - #419
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs real behavior proof before merge. Reviewed August 25, 2026, 8:18 PM ET / August 26, 2026, 00:18 UTC. ClawSweeper reviewWhat this changesThe PR forwards browser-captured downloadable files to the CLI and copies verified files beside a requested Merge readiness⛔ Blocked until real behavior proof is added - 3 items remain Keep open pending required real-behavior proof. The source change is focused and appears to repair the dropped saved-file boundary, but the PR explicitly reports that no Chrome or live browser was run. Priority: P2 Review scores
Verification
Live VerificationCommand: Result: PASS (completed) Assertions:
How this fits togetherOracle’s browser runner captures ChatGPT response artifacts, then returns them through the session runner to the CLI. The CLI writes the answer, records session metadata, and now also places verified file artifacts beside that answer. flowchart LR
A[ChatGPT browser response] --> B[Artifact capture]
B --> C[Browser session runner]
C --> D[CLI session runner]
D --> E[Write answer output]
D --> F[Copy verified saved files]
F --> G[Session artifacts and warnings]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the typed handoff and verified collision-safe copies, then demonstrate a real browser-generated file copied beside the requested output without exposing account data or private paths. Do we have a high-confidence way to reproduce the issue? Yes—source-reproducible: current main captures Is this the best way to solve the issue? Yes—the typed handoff plus exclusive copy, byte/hash verification, and warning-on-failure is a narrow maintainable repair; it still needs after-fix behavior proof. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 79e483bd9dc8. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
savedFilesthrough the session-runner boundary--write-outputfileValidation
pnpm run check: formatting, TypeScript, and oxlint passedsandbox:/mnt/data/report.md, exact bytes/hash, collision behavior, and copy failureNo Chrome or live browser was launched. The branch includes a normal merge of current upstream
main; no rebase or force-push was used.