Synchronise 2025.1 with upstream - #23
Merged
Merged
Conversation
Change Ib27f8ee08184a061beef28192bce39f690c9eaa3 applied shlex.quote() to the console command. socat runs EXEC: commands via execvp(), not a shell, so the quoted command line was taken as a single program name and the console failed to start with "No such file or directory". Escape socat's own address metacharacters instead, which keeps the arguments separated and still stops a metacharacter in, say, ipmi_username from injecting socat options. Closes-Bug: #2162414 Related-Bug: #2148331 Assisted-by: Claude Opus 5 Change-Id: I3820b0fad25a2f67fb77415d3fbd528b28e64c1e Signed-off-by: Afonne-CID <afonnepaulc@gmail.com> (cherry picked from commit 04a0a19)
github-actions
Bot
added
automated
priteau
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2025.1 from upstream stable/2025.1.