Allow fluent use of InetAddressMatchers#builder#19074
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Allow fluent use of InetAddressMatchers#builder#19074therepanic wants to merge 1 commit intospring-projects:mainfrom
InetAddressMatchers#builder#19074therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
The main goal of this commit is to allow fluent use of `InetAddress Matchers#builder` to be called in a fluent manner. Previously, calling `includeAddresses` twice would cause the logic to stop working, since our IP address can't be equal to two addresses in the list at the same time. I think the current behavior is rather non-obvious, and we should definitely implement this change. Closes: spring-projectsgh-19071 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
commented
Apr 14, 2026
Comment on lines
+98
to
+100
| private final Set<String> includeAddresses = new LinkedHashSet<>(); | ||
|
|
||
| private final Set<String> excludeAddresses = new LinkedHashSet<>(); |
Contributor
Author
There was a problem hiding this comment.
Would it be more obvious if we used LinkedHashSet? When debugging, the user will see the addresses added to the list in the order they were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this commit is to allow fluent use of
InetAddress Matchers#builderto be called in a fluent manner.Previously, calling
includeAddressestwice would cause the logic to stop working, since our IP address can't be equal to two addresses in the list at the same time.I think the current behavior is rather non-obvious, and we should definitely implement this change.
Closes: gh-19071