Fix InetAddressMatchers#matchExternal to exclude null and any local addresses#19073
Open
therepanic wants to merge 1 commit intospring-projects:mainfrom
Open
Fix InetAddressMatchers#matchExternal to exclude null and any local addresses#19073therepanic wants to merge 1 commit intospring-projects:mainfrom
InetAddressMatchers#matchExternal to exclude null and any local addresses#19073therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
…ddresses This commit fixes the incorrect behavior of `InetAddressMatchers#matchExternal`, where `matchExternal` returns an incorrect answer when passing a null / local address argument, which is not reliable. Closes: spring-projectsgh-19072 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
therepanic
commented
Apr 14, 2026
Comment on lines
259
to
263
| } | ||
| if (address.isAnyLocalAddress()) { | ||
| return true; | ||
| } | ||
| if (address.isLoopbackAddress() || address.isLinkLocalAddress() || address.isSiteLocalAddress()) { |
Contributor
Author
There was a problem hiding this comment.
This would probably be more elegant than adding the same check but on matchExternal, since the logic of matchExternal is to return the response back from matchInternal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the incorrect behavior of
InetAddressMatchers#matchExternal, wherematchExternalreturns an incorrect answer when passing a null / local address argument, which is not reliable.Closes: gh-19072