Feature: Improve AbstractAuthenticationFilterConfigurer by only using one instance of successHandler#19070
Open
AB-xdev wants to merge 1 commit intospring-projects:mainfrom
Conversation
AB-xdev
force-pushed
the
abstractAuthenticationFilterConfigurer-use-one-successhandler
branch
from
3f6aeb3 to
6ca983c
Compare
spring-projects-issues
added
the
status: waiting-for-triage
AB-xdev
force-pushed
the
abstractAuthenticationFilterConfigurer-use-one-successhandler
branch
from
6ca983c to
36b0da1
Compare
AB-xdev
force-pushed
the
abstractAuthenticationFilterConfigurer-use-one-successhandler
branch
from
36b0da1 to
a6a1cfc
Compare
…ance of successHandler Instead of keeping 2 instances of successHandler (defaultSuccessHandler) only one is kept and the request cache is only set if the instance implements `HasRequestCacheSetter` and the `trySetRequestCacheIntoSuccessHandler` flag is set to true (default). This way it's also easier for devs to customize the corresponding code as RequestCache must no longer be set manually when supplying a custom SuccessHandler. Signed-off-by: AB <a.bierler@xdev-software.de>
AB-xdev
force-pushed
the
abstractAuthenticationFilterConfigurer-use-one-successhandler
branch
from
a6a1cfc to
cbe9dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19123
Instead of keeping 2 instances of successHandler (defaultSuccessHandler) only one is kept and the request cache is only set if the instance implements
HasRequestCacheSetterand thetrySetRequestCacheIntoSuccessHandlerflag is set to true (default).This way it's also easier for devs to customize the corresponding code as RequestCache must no longer be set manually when supplying a custom SuccessHandler.