Add RESPECT_JSONPROPERTY_ORDER to JsonSchemaGenerator #5798
Open
chanani wants to merge 2 commits intospring-projects:mainfrom
Open
Add RESPECT_JSONPROPERTY_ORDER to JsonSchemaGenerator #5798chanani wants to merge 2 commits intospring-projects:mainfrom
chanani wants to merge 2 commits intospring-projects:mainfrom
Conversation
Align JacksonSchemaModule configuration with BeanOutputConverter to honor @JsonPropertyOrder when generating JSON See spring-projectsgh-5797 Signed-off-by: CHANHAN <130114269+chanani@users.noreply.github.com>
Signed-off-by: CHANHAN <130114269+chanani@users.noreply.github.com>
Contributor
Author
|
The failing test (WebClientStreamableHttpTransportErrorHandlingIT.testSessionRecoveryAfter404) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JsonSchemaGeneratorwas missingJacksonOption.RESPECT_JSONPROPERTY_ORDERin its
JacksonSchemaModuleconfiguration, whileBeanOutputConverteralready includes it. As a result,
@JsonPropertyOrderannotations wereignored when generating JSON schemas via
ResponseFormat.jsonSchema().Changes
JacksonOption.RESPECT_JSONPROPERTY_ORDERtoJsonSchemaGenerator@JsonPropertyOrderis respected in schema generationSee gh-5797