fix(constant): correct typos in state key constants#543
Open
WinSalty wants to merge 1 commit into
Open
Conversation
Rename GENEGRATED_SEMANTIC_MODEL_PROMPT to GENERATED_SEMANTIC_MODEL_PROMPT and COLUMN_DOCUMENTS__FOR_SCHEMA_OUTPUT to COLUMN_DOCUMENTS_FOR_SCHEMA_OUTPUT. Both identifiers and their string values are updated across 8 files (24 references). These constants are only used as in-memory StateGraph keys — no persistence or API impact. Closes spring-ai-alibaba#542 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
@zxuexingzhijie 您好，之前的Copilot额度超了，review未正常进行，麻烦重新发起。 |
Collaborator
|
奇了怪了 我自己看一下 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GENEGRATED_SEMANTIC_MODEL_PROMPT→GENERATED_SEMANTIC_MODEL_PROMPT(typo:GENEGRATED)COLUMN_DOCUMENTS__FOR_SCHEMA_OUTPUT→COLUMN_DOCUMENTS_FOR_SCHEMA_OUTPUT(double underscore__→ single_)These constants are only used as in-memory
OverAllStatekeys in the StateGraph workflow — no database persistence, API serialization, or frontend mapping is affected.Closes #542
Changed files
Constant.javaDataAgentConfiguration.javaTableRelationNode.javaSchemaRecallNode.javaCOLUMN_DOCUMENTS_FOR_SCHEMA_OUTPUT)PlannerNode.javaGENERATED_SEMANTIC_MODEL_PROMPT)SchemaRecallNodeTest.javaTableRelationNodeTest.javaPlannerNodeTest.javaTest plan
SchemaRecallNodeTest— 6 tests passedTableRelationNodeTest— 7 tests passedPlannerNodeTest— 9 tests passedspring-javaformat:apply— no formatting changes neededcheckstyle:check— 0 violations