Skip to content

Fix for release to PyPi build step bug #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miclegr merged 3 commits into from
Sep 25, 2025
Merged

Fix for release to PyPi build step bug #124

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5557f79
impl
miclegr Sep 23, 2025
ff563e9
fix java lint error
miclegr Sep 23, 2025
a399513
update step name
miclegr Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Set up JDK 11
Copy link
Copy Markdown
Contributor

@stephen29xie stephen29xie Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 17 to match

Copy link
Copy Markdown
Contributor Author

@miclegr miclegr Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, done :)

uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '17'
distribution: 'corretto'
- name: Check Formatting
run: mvn --batch-mode com.spotify.fmt:fmt-maven-plugin:check
Expand Down Expand Up @@ -456,8 +456,9 @@ jobs:
steps:
- uses: actions/download-artifact@v4
with:
name: python-wheels
pattern: python-wheels-*
path: dist
merge-multiple: true
- uses: actions/download-artifact@v4
with:
name: python-sdist
Expand Down
Loading