Fix BigQuery unsupported type with Method.DEFAULT of Joda LocalDateTime#5922
Open
subhramit wants to merge 6 commits intospotify:mainfrom
Open
Fix BigQuery unsupported type with Method.DEFAULT of Joda LocalDateTime#5922subhramit wants to merge 6 commits intospotify:mainfrom
Method.DEFAULT of Joda LocalDateTime#5922subhramit wants to merge 6 commits intospotify:mainfrom
Conversation
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
subhramit
changed the title
Method.DEFAULT of Joda LocalDateTimeMethod.DEFAULT of Joda LocalDateTime
Signed-off-by: subhramit <subhramit.bb@live.in>
Signed-off-by: subhramit <subhramit.bb@live.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5596
Post-process the Avro schema fields by correlating them with the original
TableSchemafields and stamping the correctlogicalTypeproperties.Note that a JSON round-trip was needed in
addLogicalTypeas Avro's Schema object locks properties after parsing. Directly callingaddPropon the original schema returned by BigQueryUtils throwsAvroRuntimeException: Can't redefine. Parsing from JSON gives a fresh mutable copy.