Skip to content

Add type bound for parquet-avro SCollection ops #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RustedBones merged 1 commit into from
Feb 9, 2024
Merged

Add type bound for parquet-avro SCollection ops #5230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scio-parquet/src/main/scala/com/spotify/scio/parquet/avro/syntax/SCollectionSyntax.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import com.spotify.scio.parquet.avro.ParquetAvroIO
import com.spotify.scio.util.FilenamePolicySupplier
import com.spotify.scio.values.SCollection
import org.apache.avro.Schema
import org.apache.avro.generic.IndexedRecord
import org.apache.hadoop.conf.Configuration
import org.apache.parquet.hadoop.metadata.CompressionCodecName

Expand All @@ -33,7 +34,7 @@ import scala.reflect.ClassTag
* Enhanced version of [[com.spotify.scio.values.SCollection SCollection]] with Parquet Avro
* methods.
*/
class SCollectionOps[T](private val self: SCollection[T]) extends AnyVal {
class SCollectionOps[T <: IndexedRecord](private val self: SCollection[T]) extends AnyVal {

/**
* Save this SCollection of Avro records as a Parquet file.
Expand Down Expand Up @@ -81,9 +82,9 @@ class SCollectionOps[T](private val self: SCollection[T]) extends AnyVal {
}

trait SCollectionSyntax {
implicit def parquetAvroSCollectionOps[T](c: SCollection[T]): SCollectionOps[T] =
implicit def parquetAvroSCollectionOps[T <: IndexedRecord](c: SCollection[T]): SCollectionOps[T] =
new SCollectionOps[T](c)
implicit def parquetAvroSCollection[T: Coder](
implicit def parquetAvroSCollection[T <: IndexedRecord: Coder](
self: ParquetAvroFile[T]
): SCollectionOps[T] =
new SCollectionOps[T](self.toSCollection)
Expand Down