BigQuery IT test with null optional and empty repeated values#5040
Draft
RustedBones wants to merge 1 commit intomainfrom
Draft
BigQuery IT test with null optional and empty repeated values#5040RustedBones wants to merge 1 commit intomainfrom
RustedBones wants to merge 1 commit intomainfrom
Conversation
RustedBones
commented
Oct 20, 2023
Comment on lines
+78
to
+79
| it should "work with selectedFields" in { | ||
| val expected = (0 until 10).map(newNestedWithFields).asJava |
Contributor
Author
There was a problem hiding this comment.
This test now fails with
Expected: iterable with items [<NestedWithFields(Required$2(0,0),None)>, <NestedWithFields(Required$2(1,1),Some(Optional$2(1)))><NestedWithFields(Required$2(2,2),Some(Optional$2(2)))>, ...] in any order
but: not matched: <NestedWithFields(Required$2(0,0),Some(Optional$2(0)))>
Tried to debug but it seems it comes from the bigquery session. avro bytes sent tell the optional.int field is set to 0. There is probably an issue with projection in the library.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5040 +/- ##
==========================================
+ Coverage 62.69% 63.12% +0.42%
==========================================
Files 301 286 -15
Lines 10848 10743 -105
Branches 773 791 +18
==========================================
- Hits 6801 6781 -20
+ Misses 4047 3962 -85 ☔ View full report in Codecov by Sentry. |
Contributor
Author
9e6d7fd to
12d2ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.