Conversation
scottlamb
suggested changes
Jul 12, 2024
| XcoderEncoderCodec::H264 { .. } => sys::_ni_codec_format_NI_CODEC_FORMAT_H264, | ||
| XcoderEncoderCodec::H265 { .. } => sys::_ni_codec_format_NI_CODEC_FORMAT_H265, | ||
| }; | ||
| (**session).pixel_format = i32::try_from(config.pixel_format.repr()).expect("cast should never fail"); |
Contributor
There was a problem hiding this comment.
I think there are a couple things elsewhere in this function that are assuming yuv420p. Search for ni_get_hw_yuv420p_dim, which probably should be replaced with ni_get_frame_dim. Could you try adding a unit test first that uses bgra? I would expect it to fail as is.
Collaborator
Author
There was a problem hiding this comment.
Ah, dang you're right. I had deluded myself into thinking that happened downstream.
Collaborator
Author
|
Updating the xcoder library seems to have induced some behavior that is a stack overflow without a debugger, and a segfault with a debugger. Pending further investigation. |
Xaeroxe
force-pushed
the
pixel-fmt
branch
2 times, most recently
from
6964695 to
44f8809
Compare
Collaborator
Author
|
Issue resolved, |
scottlamb
reviewed
Jul 16, 2024
Collaborator
Author
|
Tests pass now, the bgra output looks good upon being inspected. |
scottlamb
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.