Skip to content

Fix incorrect URL being shown to user during just-in-time plugin install #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itowlson merged 1 commit into from
May 7, 2026
+10 −2
Merged

Fix incorrect URL being shown to user during just-in-time plugin install #3499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/commands/external.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,12 +214,20 @@ fn match_catalogue_plugin(
plugin_store: &PluginStore,
plugin_name: &str,
) -> Option<spin_plugins::manifest::PluginManifest> {
use itertools::Itertools;

let Ok(known) = plugin_store.catalogue_manifests() else {
return None;
};
known
let candidates = known
.into_iter()
.find(|m| m.name() == plugin_name && m.has_compatible_package())
.filter(|m| m.name() == plugin_name && m.has_compatible_package());

// We care about getting the latest because it's the return of this that is used
// to show the plugin installation offer to the user (e.g. URL).
let mut candidates_latest_first =
candidates.sorted_by(|a, b| b.compare_versions(a).unwrap_or(std::cmp::Ordering::Equal));
candidates_latest_first.next()
}

async fn report_badger_result(badger: tokio::task::JoinHandle<BadgerChecker>) {
Expand Down
Loading