fix handling of KV set and throw wrapped errors#379
Open
karthik2804 wants to merge 1 commit intomainfrom
Open
Conversation
Signed-off-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com>
Collaborator
Author
|
@tschneidereit I am not really sure about the error part and wonder if handling the error should be a user concern instead of us wrapping it. |
tschneidereit
approved these changes
Sep 30, 2025
Collaborator
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
I think that's an okay workaround, yes. It's somewhat unfortunate that the generated bindings have cyclic structures, but we should look into tackling that with the move to wit-dylib in time.
Comment on lines
+62
to
+63
| } else if (value instanceof ArrayBuffer) { | ||
| value = new Uint8Array(value); |
Collaborator
There was a problem hiding this comment.
Tiniest of nits: I would move this to the top so the encode cases stay grouped
radu-matei
approved these changes
Nov 7, 2025
Member
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
Anything else before merging this?
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple of small bugs that I ran into.
ArrayBufferproperly in KV set operations.