Skip to content

a11y: make the sidebar button a <button> #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugovk wants to merge 4 commits into
base: master
Choose a base branch
from
Open

a11y: make the sidebar button a <button> #14326

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4673397
a11y: make the sidebar button a <button>
hugovk Feb 28, 2026
b80109e
Add to changelog
hugovk Mar 6, 2026
f087e3b
Add type="button"
hugovk Mar 23, 2026
c965d94
Merge branch 'master' into sidebar-button
hugovk Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,29 @@
Release 9.2.0 (in development)
==============================

Dependencies
------------

Incompatible changes
--------------------

* #14326: The sidebar button in the classic theme has changed from a ``<div>``
to a ``<button>``. If you have custom styles for ``div#sidebarbutton``, you
may need to change the filter to ``#sidebarbutton``.
Patch by Hugo van Kemenade

Deprecated
----------

Features added
--------------

Bugs fixed
----------

Testing
-------

Release 9.1.0 (released Dec 31, 2025)
=====================================

Expand Down
4 changes: 2 additions & 2 deletions sphinx/themes/classic/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
{%- endblock %}

{%- block sidebarextra %}{% if theme_collapsiblesidebar|tobool %}
<div id="sidebarbutton" title="{{ _('Collapse sidebar') }}">
<button id="sidebarbutton" title="{{ _('Collapse sidebar') }}">
Comment thread
hugovk marked this conversation as resolved.
Resolved
<span>{{ '»' if theme_rightsidebar|tobool else '«' }}</span>
</div>
</button>
{% endif %}{% endblock %}
4 changes: 3 additions & 1 deletion sphinx/themes/classic/static/classic.css.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,12 @@ div.sphinxsidebar input {
background-color: {{ theme_sidebarbtncolor }};
margin-{{side}}: 0;
color: #FFFFFF;
border: none;
border-{{side}}: 1px solid {{ theme_relbarbgcolor }};
font: inherit;
font-size: 1.2em;
cursor: pointer;
padding-top: 1px;
padding: 1px 0 0;
float: {{ 'left' if theme_rightsidebar|tobool else 'right' }};
display: table; /* for vertically centering the <span> */
}
Expand Down
2 changes: 1 addition & 1 deletion sphinx/themes/pyramid/static/epub.css.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ div.sphinxsidebar input {

{% if theme_collapsiblesidebar|tobool %}
/* for collapsible sidebar */
div#sidebarbutton {
#sidebarbutton {
background-color: {{ theme_sidebarbtncolor }};
}
{% endif %}
Expand Down
Loading