qml/android: protect WIF keys from screenshots in more places - #10799
Merged
accumulator merged 1 commit intoAug 7, 2026
Conversation
SomberNight
commented
Aug 5, 2026
SomberNight
force-pushed
the
202608_android_secure_window
branch
2 times, most recently
from
August 5, 2026 15:10
241dccd to
65aae21
Compare
accumulator
reviewed
Aug 7, 2026
| property: 'secureWindow' | ||
| value: seedText.visible | ||
| when: rootItem.visible // enables stacking multiple secureWindow dialogs | ||
| value: true |
Member
There was a problem hiding this comment.
Now this page will always be 'secured', even when no secrets are shown?
Member
Author
There was a problem hiding this comment.
thanks, that was not intentional.
force-pushed https://github.com/spesmilo/electrum/compare/65aae21ae15a332f1c8704235c0fc4eb2b09910d..739cba5d7e582571cc7a7201294b5f66d7a9b52f
also fix bug in AddressDetails where we were never unsetting the secure flag
notes re dialog stacking:
- if we stack two "secure" dialogs and then pop one of them, the remaining "secure" dialog should still have secureWindow == true.
- we could either impl some refcounting for the number of alive "secure" dialogs
- or perhaps simpler but less robust, qml binding magic using the "when" as done here might work?
- ref https://doc.qt.io/qt-6/qml-qtqml-binding.html#restoreMode-prop
- the default restoreMode (Binding.RestoreBindingOrValue) seems to do what we want here
- I don't explicitly set it as the Qt docs have this note:
> Note: This property exists for backwards compatibility with earlier versions of Qt. Don't use it in new code.
- seems to work on my phone
SomberNight
force-pushed
the
202608_android_secure_window
branch
from
August 7, 2026 09:51
65aae21 to
739cba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also fix bug in AddressDetails where we were never unsetting the secure flag