wallet: sign_message: strip whitespaces in GUis, do not strip in CLI - #10791
Merged
SomberNight merged 1 commit intoAug 3, 2026
Merged
Conversation
SomberNight
force-pushed
the
202608_wallet_sign_message2
branch
3 times, most recently
from
August 3, 2026 14:09
0b293ea to
351b274
Compare
- stripping whitespaces leads to better UX for GUIs IMO, but it's counter-productive for CLI - our previous behaviour was unintentionally inconsistent: - qt stripped the message in both sign and verify - qml stripped the message in verify but not in sign (until spesmilo#10787) - cli stripped the message in both sign and verify - qml also stripped the signature in verify, which was not done anywhere else - now this code is de-duped, and the default becomes stripping both message and signature; with the CLI explicitly opting out of that ref spesmilo#4327 closes spesmilo#10787 closes spesmilo#10788
SomberNight
force-pushed
the
202608_wallet_sign_message2
branch
from
August 3, 2026 14:47
351b274 to
4c3064f
Compare
Member
Author
I think we stand-by that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(stacked on top of #10790, which is mostly clean-up, merge that first)
The design decision to make is if we stand-by the stance from #4327:
closes #10787
closes #10788