Skip to content

wallet: sign_message: strip whitespaces in GUis, do not strip in CLI - #10791

Merged
SomberNight merged 1 commit into
spesmilo:masterfrom
SomberNight:202608_wallet_sign_message2
Aug 3, 2026
Merged

wallet: sign_message: strip whitespaces in GUis, do not strip in CLI#10791
SomberNight merged 1 commit into
spesmilo:masterfrom
SomberNight:202608_wallet_sign_message2

Conversation

@SomberNight

@SomberNight SomberNight commented Aug 2, 2026

Copy link
Copy Markdown
Member

(stacked on top of #10790, which is mostly clean-up, merge that first)


The design decision to make is if we stand-by the stance from #4327:

In the command line, having whitespaces is very explicit, the user is fully aware;
unlike in Qt, where it's not so clear, so it's better to strip there.


  • stripping whitespaces leads to better UX for GUIs IMO, but it's counter-productive for CLI
  • our previous behaviour was unintentionally inconsistent:
  • now this code is de-duped, and the default becomes stripping both message and signature; with the CLI explicitly opting out of that

closes #10787
closes #10788

@SomberNight SomberNight added the topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py label Aug 2, 2026
@SomberNight
SomberNight force-pushed the 202608_wallet_sign_message2 branch 3 times, most recently from 0b293ea to 351b274 Compare August 3, 2026 14:09
- stripping whitespaces leads to better UX for GUIs IMO, but it's counter-productive for CLI
- our previous behaviour was unintentionally inconsistent:
  - qt stripped the message in both sign and verify
  - qml stripped the message in verify but not in sign (until spesmilo#10787)
  - cli stripped the message in both sign and verify
  - qml also stripped the signature in verify, which was not done anywhere else
- now this code is de-duped, and the default becomes stripping both message and signature; with the CLI explicitly opting out of that

ref spesmilo#4327
closes spesmilo#10787
closes spesmilo#10788
@SomberNight
SomberNight force-pushed the 202608_wallet_sign_message2 branch from 351b274 to 4c3064f Compare August 3, 2026 14:47
@SomberNight

Copy link
Copy Markdown
Member Author

The design decision to make is if we stand-by the stance from #4327

I think we stand-by that.
Hence this PR does not change the intent of the code and is just a clean-up.

@SomberNight
SomberNight merged commit b1aa52d into spesmilo:master Aug 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-wallet 👛 related to wallet.py, or maybe address_synchronizer.py/coinchooser.py

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant