Correcting #163 to exclude activation_time from /staged PATCH - #169
Open
lo-simon wants to merge 1 commit into
Open
Correcting #163 to exclude activation_time from /staged PATCH#169lo-simon wants to merge 1 commit into
activation_time from /staged PATCH#169lo-simon wants to merge 1 commit into
Conversation
…-05. In IS-05, the activation object fields are: mode requested_time So this new logic should include activation but sanitize it to only schema-valid fields (at minimum, exclude activation_time).
garethsb
approved these changes
Jul 30, 2026
garethsb
left a comment
garethsb
left a comment
Contributor
There was a problem hiding this comment.
Sounds correct and looks plausible. @jonathan-r-thorpe should/could this have been caught by controller tests somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting #163
activation_timeshould not be sent in /staged PATCH requests for IS-05.In IS-05, the activation object fields are:
So this new logic should include activation but sanitise it to only schema-valid fields (at minimum, exclude activation_time).