Skip to content

Always include a requested activation in the connection PATCH #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lo-simon merged 2 commits into from
Jul 30, 2026
+14 −0
Merged

Always include a requested activation in the connection PATCH #163

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055ca89
Always include a requested activation in the connection PATCH
ZayanKhan-12 Jul 25, 2026
6a391cc
Expand comment explaining why a requested activation is always includ…
ZayanKhan-12 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Development/src/dataProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,18 @@ const convertDataProviderRequestToHTTP = (
JsonPointer.set(patchData, `/${d.path.join('/')}`, d.rhs, true);
}

// the activation object in a PATCH requests an activation, rather
// than reflecting staged state, so when a mode is set, include it
// even if the staged endpoint already reported the same values,
// which otherwise leaves it out of the differences (see #97)

@garethsb garethsb Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// the activation object in a PATCH requests an activation, rather
// than reflecting staged state, so when a mode is set, include it
// even if the staged endpoint already reported the same values,
// which otherwise leaves it out of the differences (see #97)
// Activation in a PATCH is a request, not staged state. Include it whenever
// the request has a non-null mode, even if GET /staged already reported the
// same values (otherwise deep-diff omits it). That also covers non-conformant
// devices that leave activate_immediate on /staged (see #97). A null mode is
// only sent when it appears in the differences, so unrelated edits do not
// cancel a pending activation.

if (get(params, 'data.$staged.activation.mode') != null) {
set(
patchData,
'activation',
get(params, 'data.$staged.activation')
);
}

if (has(patchData, 'transport_file')) {
if (get(patchData, 'transport_file.data') === null) {
set(patchData, 'transport_file.type', null);
Expand Down
Loading