[supervisord] implement sd_notify#24191
Open
stepanblyschak wants to merge 4 commits into
Open
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Oct 2, 2025
| From: Stepan Blyschak <stepanb@nvidia.com> | ||
| Date: Mon, 29 Sep 2025 14:09:22 +0000 | ||
| Subject: [PATCH] Implement SD_NOTIFY | ||
|
|
Collaborator
There was a problem hiding this comment.
Could you submit (just submit) a PR to https://github.com/Supervisor/supervisor ?
qiluo-msft
reviewed
Oct 2, 2025
| + def close_notify_socket(self): | ||
| + if self.notify_sock is None: | ||
| + return | ||
| + self.notify_sock.close() |
Collaborator
There was a problem hiding this comment.
Will you self.notify_sock = None after close it?
qiluo-msft
reviewed
Oct 2, 2025
| url = https://github.com/Marvell-switching/mrvl-teralynx.git | ||
| [submodule "src/supervisor"] | ||
| path = src/supervisor | ||
| url = https://github.com/Supervisor/supervisor |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Not sure why needed, I pin submodule to specific commit
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
@StormLiangMS Can this be used a a sync mechanism between FRR and bgpcfgd to address #23938? |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@qiluo-msft can you please approve so i can merge? i want it to get to 202511 before it is branched out. |
Collaborator
@qiluo-msft - Can you please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPENDS ON #24190
Why I did it
Most Linux daemons support notifying init (usually systemd) about readiness. This is when systemd makes the process enter Started state. This is useful as sync mechanism between deamons.
We do have similar use cases for SONiC with supervisord. But in supervisord this works only with startsecs delay. This partially addresses #13765
Work item tracking
How I did it
Implemented
sd_notifyHow to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)