Re-baseline bundlewatch budgets, add MPL-2.0 to the license allowlist, fix dead config in the e2e runner (#1309, #1310, #1311, #1312) - #1461
Open
Johnero542 wants to merge 1 commit into
Conversation
…, fix dead config in the e2e runner (solutions-plug#1309, solutions-plug#1310, solutions-plug#1311, solutions-plug#1312) solutions-plug#1310: bundlewatch.config.json's paths (.next/static/chunks/vendor.js, main*.js, pages/_app*.js) were Pages Router / classic-webpack chunk naming conventions — this app is App Router (src/app/), built with Next.js 16's default Turbopack, so none of those paths ever match any real build output; the budget check was silently a no-op. Re-baselined to App Router chunk conventions (framework-*.js, main-app-*.js, app/page-*.js) plus explicit budgets for the markets and admin route bundles named in the issue's background. solutions-plug#1311: current frontend dependencies don't yet include a wallet SDK/ charting/i18n library (those are hand-rolled: useWalletAddress.ts, useI18n.ts, etc.), so that specific background concern doesn't apply yet. But axe-core — already a devDependency — is licensed MPL-2.0, which wasn't in the onlyAllow list at all (only Apache-2.0/Apache* was present, not MPL). Added MPL-2.0. solutions-plug#1312: package.json's generate-client script + build prerequisite (`build: npm run generate-client && next build`), services/api/ openapi.yaml, and src/lib/api/schema.d.ts all already exist and are already wired together exactly as described, with dedicated contract tests (client-schema-type-contract.test.ts, client-schema-path-contract.test.ts) guarding against drift. Diffed every path in openapi.yaml against schema.d.ts directly — they match exactly. No gap found; nothing changed here. solutions-plug#1309: playwright.config.ts already configures chromium/firefox/webkit/ mobile-chrome/mobile-safari/tablet plus integration and staging projects — already well beyond what the issue asks for. The real, still-live gap was in scripts/run-e2e-tests.js (also named in the issue): it built a `config` object (workers/retries/reporter) and printed it as "Configuration", but the actual invoked command hardcoded `--reporter=github,html,json,junit` in CI and computed nothing else — `config` had zero effect on what actually ran. Rebuilt the command from `config` so the printed configuration is the real one. Closes solutions-plug#1309 Closes solutions-plug#1310 Closes solutions-plug#1311 Closes solutions-plug#1312 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014jDDop7frnew1xcCJDSKEw
|
@Johnero542 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundlewatch.config.json's paths (.next/static/chunks/vendor.js,main*.js,pages/_app*.js) were Pages Router / classic-webpack chunk naming conventions — this app is App Router (src/app/), built with Next.js 16's default Turbopack, so none of those paths ever matched any real build output; the budget check was silently a no-op. Re-baselined to App Router chunk conventions (framework-*.js,main-app-*.js,app/page-*.js) plus explicit budgets for the markets and admin route bundles named in the issue's background.useWalletAddress.ts,useI18n.ts, etc.), so that specific background concern doesn't apply yet. Butaxe-core— already a devDependency — is licensed MPL-2.0, which wasn't in theonlyAllowlist at all. AddedMPL-2.0.package.json'sgenerate-clientscript + build prerequisite,services/api/openapi.yaml, andsrc/lib/api/schema.d.tsall already exist and are already wired together exactly as described, with dedicated contract tests guarding against drift. Diffed every path inopenapi.yamlagainstschema.d.tsdirectly — they match exactly. No gap found; nothing changed here.playwright.config.tsalready configures chromium/firefox/webkit/mobile-chrome/mobile-safari/tablet plus integration and staging projects — already well beyond what the issue asks for. The real, still-live gap was inscripts/run-e2e-tests.js(also named in the issue): it built aconfigobject and printed it as "Configuration", but the actual invoked command hardcoded its reporter flag in CI and computed nothing else —confighad zero effect on what actually ran. Rebuilt the command fromconfigso the printed configuration is the real one.Test plan
services/api/openapi.yamlandsrc/lib/api/schema.d.tsto confirm [Frontend Scaffolding] Wire OpenAPI-to-TypeScript client codegen into the build #1312 has no driftonlyAllowlist to find [Frontend Scaffolding] Set up license-checker allowlist #1311's real (single) gapCloses #1309
Closes #1310
Closes #1311
Closes #1312