feat(landing,seo): Step + FooterColumn rebuild, SEO metadata, responsive hardening (#1345 #1346 #1347 #1348) - #1458
Open
techisigu wants to merge 3 commits into
Open
Conversation
|
@techisigu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landing page: Step, FooterColumn, SEO metadata, responsive
Four landing-page issues.
What changed and why
#1345 - Step component + real "how it works" flow
Steptakes an optionalhrefand links the step title to the corresponding feature.The step number is not passed in -
landing.cssalready derives it with a CSScounter()from the<ol>order, so it can't drift from the visual list.markets -> place a bet -> claim a payout (i18n
howItWorks.*), each linking to/marketsor
/account/bets.href; no hardcoded numbering inthe DOM; the
LandingPagedata-driven test asserts the<ol>and the four step links.#1346 - FooterColumn + real footer navigation
FooterColumngains achildrenslot (for embeds) and anexternallink flag(
target="_blank"+rel="noopener noreferrer")./markets,Statistics
/statistics, Create a market/markets/create), Resources (Documentation +GitHub, both external), and a "stay in the loop" column linking back to the hero signup
form (a second
<NewsletterSignup>would duplicate its field ids and break a11y). Thedead
/docs,/github(internal),/discord,/privacy,/termslinks and the Legalcolumn were removed - there are no such pages.
e2e/landing-links-responsive.spec.tsasserts every internal footer link resolves(
request.get(href)< 400) - the CI link-check the AC asks for.childrenrender; the data-driven test nowasserts real routes and the absence of the removed links.
#1347 - SEO metadata + structured data
app/layout.tsx: site-wide defaults -metadataBase, atitletemplate, Open GraphsiteName/url, Twittersummary_large_image.app/page.tsx(kept server-side, still code-split vianext/dynamicwithssr: trueandthe existing loading fallback): route-level
title/description/ canonical / fullOpen Graph + Twitter with an
/og-image.png, plus anOrganization+WebSiteJSON-LD<script type="application/ld+json">(a build-time constant, server-rendered solink-unfurl crawlers see it).
enbundle today;
SITE_URLreadsNEXT_PUBLIC_SITE_URLwith a default.landing-metadata.test.tsasserts the exportedmetadatashape and the layoutdefaults.
#1348 - responsive hardening
overflow-wrap: anywhereon hero/feature/step/footer text so a long word in a translatedlocale wraps instead of widening the page.
minmax(min(100%, 230px), 1fr)so a track can shrink below itscontent's min-content size;
.footer-content { max-width: 100% }.@media (max-width: 360px)block forces single-column grids and trims inline padding.e2e/landing-links-responsive.spec.tsassertsscrollWidth - clientWidth <= 1at 320 /768 / 1440.
How to test
page.test.tsx(the dynamic-loading fallbacktest) still passes - the code-split + loading spinner were preserved.
tsc --noEmit: no errors in the touched files over the repo's pre-existing count.e2e/landing-links-responsive.spec.tsnot run here (needs the browser install).main, unchanged by this branch (verified against a cleanupstream/mainworktree - identical 30 failures):
Statistics.test.tsx,LandingPage.keyboard.test.tsx,LandingPage.accessibility.test.tsx,useAsync.test.ts,useReferral.test.ts.Breaking changes
None. New props and metadata only. Footer link targets changed (removed dead links).
Related issues
Closes #1345
Closes #1346
Closes #1347
Closes #1348
PR Checklist
main