Skip to content

Fix/829 admin host universities pagination - #630

Open
whqtker wants to merge 2 commits into
mainfrom
fix/829-admin-host-universities-pagination
Open

Fix/829 admin host universities pagination#630
whqtker wants to merge 2 commits into
mainfrom
fix/829-admin-host-universities-pagination

Conversation

@whqtker

@whqtker whqtker commented Aug 11, 2026

Copy link
Copy Markdown
Member

서버의 page 계약은 1-indexed인데 이 화면의 UI 상태는 0부터 시작해 그대로 요청에 실려 보내고 있었다. page=0과 page=1 요청이 모두 서버 내부에서 동일한 오프셋으로 클램프되어, "다음" 버튼을 처음 눌렀을 때 같은 목록이 다시 보이고 마지막 페이지에는 영원히 도달하지 못했다.

API 호출 시점에만 page + 1로 변환해 서버 계약에 맞춘다.

whqtker and others added 2 commits August 11, 2026 14:28
서버의 page 계약은 1-indexed인데 이 화면의 UI 상태는 0부터 시작해
그대로 요청에 실려 보내고 있었다. page=0과 page=1 요청이 모두 서버
내부에서 동일한 오프셋으로 클램프되어, "다음" 버튼을 처음 눌렀을 때
같은 목록이 다시 보이고 마지막 페이지에는 영원히 도달하지 못했다.

API 호출 시점에만 page + 1로 변환해 서버 계약에 맞춘다.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WTCqRi8V2TJ1ZqHpfiQ1vy
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WTCqRi8V2TJ1ZqHpfiQ1vy
@whqtker whqtker self-assigned this Aug 11, 2026
@whqtker
whqtker requested a review from wibaek as a code owner August 11, 2026 05:41
@whqtker whqtker added the bug Something isn't working label Aug 11, 2026
@whqtker
whqtker requested a review from manNomi as a code owner August 11, 2026 05:41
@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview Aug 11, 2026 5:41am
solid-connect-web-admin Ready Ready Preview Aug 11, 2026 5:41am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connection-web Skipped Skipped Aug 11, 2026 5:41am

@github-actions github-actions Bot added the admin label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14a18d21-00d6-4773-9633-718daa0c7cca

📥 Commits

Reviewing files that changed from the base of the PR and between 62477e3 and d7138ae.

📒 Files selected for processing (1)
  • apps/admin/src/components/features/univ-apply-infos/tabs/HostUniversityTab.tsx

Walkthrough

1. 대학 목록 페이지 번호 변환
 대학 목록 조회 요청에서 searchParams.page + 1을 API 페이지 번호로 전달합니다. 페이지 크기는 20으로 유지됩니다.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: wibaek, mannomi

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 관리자 호스트 대학 목록의 페이지네이션 수정이라는 주요 변경 사항을 명확하고 간결하게 설명합니다.
Description check ✅ Passed 페이지네이션 문제의 원인과 API 요청 시 page 변환 방식을 명확히 설명하며, 작업 내용이 변경 사항과 일치합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/829-admin-host-universities-pagination

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admin bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant