Add observationUnitDbId as a valid header to phenotype upload info#6084
Open
bm743 wants to merge 1 commit into
Open
Add observationUnitDbId as a valid header to phenotype upload info#6084bm743 wants to merge 1 commit into
bm743 wants to merge 1 commit into
Conversation
ryan-preble
reviewed
May 5, 2026
Contributor
ryan-preble
left a comment
ryan-preble
left a comment
There was a problem hiding this comment.
Does the relevant file parser have a way to check whether it is getting a uniquename or a stock_id and search for the right stock accordingly?
Contributor
Author
You're right, this column in the phenotype spreadsheet upload only works for observationUnitName. I'll have to ask Heather if she wants the ID added to this upload or if she was referring to something else. |
ryan-preble
requested changes
May 13, 2026
Contributor
ryan-preble
left a comment
ryan-preble
left a comment
There was a problem hiding this comment.
If observationUnitDbId is added as a valid header it also needs to be an alias on the upload parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6011
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.