Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Clean up/forwarder#30721

Closed
apfitzge wants to merge 5 commits into
solana-labs:masterfrom
apfitzge:clean_up/forwarder
Closed

Clean up/forwarder#30721
apfitzge wants to merge 5 commits into
solana-labs:masterfrom
apfitzge:clean_up/forwarder

Conversation

@apfitzge
Copy link
Copy Markdown
Contributor

Problem

Worker threads with transaction scheduler will not use same BankingStageStats structs or buffers. Want to separate the buffer and stats from core logic of forwarding so we aren't forced to use them.

Summary of Changes

Create forward method (and additional separation within) which does the forwarding and collects stats, but does not record to banking stage stats.

Fixes #

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2023

Codecov Report

Merging #30721 (a2c3f5b) into master (505e3ff) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##           master   #30721   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         723      723           
  Lines      201638   201647    +9     
=======================================
+ Hits       164691   164727   +36     
+ Misses      36947    36920   -27     

@apfitzge
Copy link
Copy Markdown
Contributor Author

dropping in favor of #30925 (and all its' dependent commits)

@apfitzge apfitzge closed this Mar 28, 2023
@apfitzge apfitzge deleted the clean_up/forwarder branch March 28, 2023 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant