This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Clean up/forwarder#30721
Closed
apfitzge wants to merge 5 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30721 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 723 723
Lines 201638 201647 +9
=======================================
+ Hits 164691 164727 +36
+ Misses 36947 36920 -27 |
Contributor
Author
|
dropping in favor of #30925 (and all its' dependent commits) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Worker threads with transaction scheduler will not use same BankingStageStats structs or buffers. Want to separate the buffer and stats from core logic of forwarding so we aren't forced to use them.
Summary of Changes
Create
forwardmethod (and additional separation within) which does the forwarding and collects stats, but does not record to banking stage stats.Fixes #