Repository navigation
Conversation
Contributor
|
React Doctor skipped this pull request — it changed no React files. Reviewed by React Doctor for commit |
Contributor
 [Medium impact] The PR appears safe to merge once migrations SummaryThis PR validates five existing database checks and pins token movement builders to approved files.
Reviews (21) · Last reviewed commit: "fix(db): renumber the validation migrati..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
GuiBibeau
force-pushed
the
claude/token-movements-5-display-enforcement
branch
from
October 23, 2026 14:01
e10b63a to
735786a
Compare
GuiBibeau
force-pushed
the
claude/token-movements-5-display-enforcement
branch
from
October 23, 2026 14:36
735786a to
d7f41aa
Compare
GuiBibeau
force-pushed
the
claude/token-movements-5-display-enforcement
branch
from
October 26, 2026 10:26
d7f41aa to
8219e80
Compare
GuiBibeau
changed the title
GuiBibeau
force-pushed
the
claude/token-movements-5-display-enforcement
branch
from
October 26, 2026 13:22
e5bc353 to
2123b4b
Compare
GuiBibeau
force-pushed
the
claude/token-movements-5-display-enforcement
branch
from
October 26, 2026 13:26
2123b4b to
03d7e59
Compare
GuiBibeau
force-pushed
the
claude/token-movements-5-display-enforcement
branch
from
October 26, 2026 13:43
557fad0 to
9d1ba36
Compare
GuiBibeau
force-pushed
the
claude/token-movements-5-display-enforcement
branch
from
October 27, 2026 09:27
a9752ca to
93ed7b8
Compare
0187 validates the expectation, mandate and leg CHECKs 0184-0186 added NOT VALID, under SHARE UPDATE EXCLUSIVE. Deploy it only after 0184-0186 are in production past their rollback window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check:value-movement fails a file that imports a transfer, unchecked transfer, Mosaic or subscriptions builder from its package outside that rule's list, and a listed file that no longer does, so the lists only shrink. A short import rule: it sees named, renamed and namespace imports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y refused PR 5 no longer lifts the builder's refusal: balances, the dashboard and a quote do not show or take display units yet, so every path keeps refusing interest-bearing and scaled mints. The terms and quote routes, three-unit balances and display entry move to one later change (open decision 7). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… parser A string key or destructuring off a namespace import names its builder; any other use of the namespace counts as every builder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…der package Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
export { token } hands the namespace out like passing it on, so it counts as
every builder; an alias name and a type-only export count as none.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… by name A parameter or local that shadows the imported namespace no longer counts as using every builder, and the namespace's own use still does. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
It moves to 0189, after the migrations it validates (0186 to 0188). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5/5 of the ADR 0012 stack, on #2525. Display units are deferred, so this PR only turns enforcement on.
NOT VALID(SHARE UPDATE EXCLUSIVE). Merge only after 0186–0188 have been in prod past the rollback window.check:value-movementfails a file that imports a transfer, uncheckedTransfer, Mosaic or subscriptions builder from its package outside that rule's list (TOKEN_MOVEMENT_BUILDERS). Lists only shrink.Verification (local, one branch at a time, on main 0d84d57): typecheck, every
check:*script,test:scripts, biome and generated-file drift clean; API 8,234, web 3,698,@sdp/solana123 tests pass. Surfpool mint matrix 12/12. Seven web tests timed out at 5 s under load and passed on rerun (this PR changes no web files). After the review fixes: the check script's tests reran 19/19;check:value-movementandtest:scriptspass.🤖 Generated with Claude Code