Skip to content

fix(tx): proper calculation of loaded account sizes for transaction v1 - #1392

Open
tiago18c wants to merge 2 commits into
solana-foundation:masterfrom
tiago18c:fix-loaded-data-size
Open

tiago18c wants to merge 2 commits into
solana-foundation:masterfrom
tiago18c:fix-loaded-data-size

Conversation

@tiago18c

@tiago18c tiago18c commented Oct 12, 2026 •

Copy link
Copy Markdown

Description

Total Account Size has incorrect values as it related to transaction v1 header (missing program data size and 64 byte overhead). This PR correctly calculates the Loaded Account Data Size according to SIMD-0186 and displays it next to the v1 size request. On LEGACY and V0 the value is left on the Accounts Card.

Preview:

A V1 transaction:
image

A LEGACY transaction
image

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the updated test waits match how account rows are fetched.

Summary

The PR counts program data and adds the 64-byte account charge when showing v1 loaded data beside its limit. Earlier transaction versions keep their total on the Accounts card.

  • Loaded-account totals include program data and 64-byte charges.
  • V1 summaries compare loaded data with the declared limit.
  • Inspector account totals use the loaded-account sizes.

Reviews (2) · Last reviewed commit: "fix(tx): fixed the flaky test" · Reviewed by Greptile

Comment thread app/features/transaction/ui/SummaryCard.tsx
@vercel

vercel Bot commented Oct 12, 2026

Copy link
Copy Markdown

@tiago18c is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
explorer Ready Ready Preview Oct 12, 2026 5:07pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — a075f355 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant