Repository navigation
Conversation
wrapMcpServerWithSentry reports two correct 4xx rejections as unhandled errors. They are 9,460 of the 9,627 events in one Sentry issue over 30 days. The handler sets transport.onerror after connect, logs both rejections at info, and passes other errors to Sentry.
|
@askov is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logs two
/mcpclient rejections at info, and keeps them out of Sentry.wrapMcpServerWithSentryreports both as unhandled errors, although/mcpreturns the correct406and400.Changes
onerrorincreateMcpRequestHandlerafterconnect, so it runs before the Sentry handler.@sentry/coreto theentity-inspectordev dependencies, so the specs run the realwrapMcpServerWithSentry.Behavior Changes
GETto/mcpwithouttext/event-streaminAcceptwrites an info log instead of a Sentry event, and still returns406.POSTto/mcpwithMCP-Protocol-Version: 2026-07-28writes an info log instead of a Sentry event, and still returns400.Sentry config
An
ignoreErrorsentry increateSentryConfigalso drops both events. It needs a second copy of the message list, and it matches a substring in every server event.Type of change
Related Issues
Closes HOO-1865
Checklist
build:infoscript to update build informationAdditional Notes
app/tx/[signature]/__tests__/page.spec.tsfails two cases onupstream/masterand on this branch.