Repository navigation
Conversation
Each page had its own UnknownDetailsCard, and the two disagreed on title, collapse and Raw mode. The entity card takes an InstructionNode and reads its frame from the surface.
|
@askov is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renders an instruction that the explorer cannot decode with one
UnknownDetailsCardon the tx page and in the inspector.Changes
UnknownDetailsCardto@entities/instruction-cardand deletes the tx-page and inspector copies.InstructionSurfaceProviderinstead of theInstructionCardComponentandresultprops.toInstructionNodeto build anInstructionNodefromix, so callers do not passprogramId.InstructionCardViewandInstructionFields.unify-instruction-card-renderingspec that every program'sUnknownDetailsCardtakes its card frame fromInstructionSurfaceProvider.Behavior Changes
<program>: Unknown Instructioninstead of<program> Instruction.Rawbutton.Type of change
Screenshots
Testing
#2. Expect the titleUnknown Program (Unk1111111111111111111111111111111111111111): Unknown Instructionand theRawandCollapsebuttons. Production showsUnknown Program (Unk1111111111111111111111111111111111111111) Instructionwith only anExpandbutton.#3. ExpectUnknown Program (5xZenqSrpGjmCYzCrcKYK3if4U2fPr9q4mVNmGWApZou): Unknown Instructionin raw mode, with the inner cards#3.1and#3.2. Production shows the same card.#3. ExpectAssociated Token Program: Create Idempotentwith six account rows and the inner cards#3.1to#3.4. Production shows the same card.Related Issues
Closes HOO-1997
Part of HOO-1267
Checklist
pnpm test,pnpm lint,pnpm typecheck)build:infoscript to update build informationAdditional Notes