Repository navigation
Add author sync, carry failures as data, render CLI output through Blocks, and simplify exit statuses - #128
Merged
Merged
Conversation
Failures carry facts and the frontends word them. Presenters return Blocks. Process exit statuses collapse to 0, 1 and 2. Setup leaves managed skill updates to update, and update imports installed edits with --from <path>. CONTEXT.md vocabulary is enforced by lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior changes to review first
exitCode. Signal termination is unchanged.update.updateimports installed edits with--from <path>.enable,enable.plan,disableanddisable.planoutput contracts each describe only their own action. No version bumps.Problem and behavior
Two things land together because the second fixes tests the first needs.
Author sync. Authors had no CLI path to keep an authored Skill workspace in step with the Registry.
authorcommands in the CLI.Failures as data and Blocks rendering. Failure wording was written where failures were raised, so the core carried sentences, frontends could not word things for their own surface, and CLI output was assembled ad hoc per command.
terminal/, enforced by lint.CONTEXT.md. A newskit/banned-termslint rule rejects the avoided terms in names and user-facing strings;architecture/terms.mjsrecords existing occurrences as debt that may only shrink.packages/cli/src/; the fixture world owns the filesystem scenarios the journeys use../storybookdeclarations are self-contained: public types live instorybook/contracts.tsand internal modules import them.store/operation-failures.ts, removing two import cycles withstate-schema.ts. Stored shapes are unchanged.packages/cli/contracts/.Scope
Replaces #127, which was the author sync half on its own. That tree could not pass CI alone: its failing tests are fixed by later commits that are part of this PR.
The Atlas app that reads these stories is not included and follows separately.
Validation
Locally at this tip:
pnpm format:check,pnpm lint,pnpm typecheck,pnpm test:e2eand the CLI package test pass, along with the CLI tests that failed in the first CI run. The full CLI and workspace suites were not run locally; CI is the full run.